photos will not sync via icloud from other devices "Set up and use of iCloud photos" does not cure!!!

Try going to iCloud.com using a computer browser to see if the items are there and whether they are from the device or the computer. That should show whether the device or the computer isn't syncing. If the computer, try going to System Preferences/iCloud and stop syncing. Wait a couple of minutes, then recheck syncing. If the device, go to Settings/Your Name/iCloud and do the above. As a last resort, you can also try signing out of iCloud and then sign in again.