how do i buy iCloud storage

By following the instructions in the article I linked to; without knowing what doesn't work, it's not possible to say.

If you're actually trying to buy storage instead of renting it, get an external drive or check non-Apple cloud storage services.

(187655)

Click here and follow the instructions. Note that iCloud storage upgrades are a rental of space on Apple's servers, not a purchase.

(187654)