Why my photo not uploading to iCloud

See the article Get help with iCloud Photos - Apple Support 

If you have Optimize Storage turned on, you might not have all of your original photos and videos on your device. To download the original photos and videos on your iOS device, go to Settings > [your name] > iCloud > Photos and select Download and Keep Originals.

thivadee Said:

"Why my photo not uploading to iCloud: Please help my iphone not upload photo to iCloud. I did all the setting turn on everything in icloud and photo"

-------

Check iCloud, Directly:

See if they reside in iCloud. As long as Photos is still enabled in iCloud on the old devices, then it will be recoverable. Go here: https://www.icloud.com/photos