should i keep signed in to icloud on my macbook pro

Basically, top level overview, it will delete or move a bunch of your files when you log out, and then when you log in again, it will download all of them again which could take a few hours if you have a lot of files. Plus, I also think you might lose the ability to track it in Find My, but don't quote me on that part.

Stay logged in, otherwise it will be a nightmare every time you log out and login.