I deleted photos from my iphone about a year ago thinking they would be saved on my icloud. Turns out my icloud synced with all my icloud devices. Now I only have my post erase photos. Is there any way to get my pictures back from icloud?????

The photos deleted from a device stays up to 30 days and the other apple devices ( iPhones / Macs ) connected / synced with same Apple ID and password on the same network , after 30 days they are erased from iCloud server automatically .

The year has passed , so there is no way to recover them from iCloud server .

See the articles https://support.apple.com/en-in/HT205856

https://support.apple.com/en-in/guide/icloud/mm08b49040b5/icloud

I deleted lots of photos from my old i phone last night and they have been permanently removed i have lost loads of my children's sports videos. I didn't know they would be lost from my new phone as well. How can i get them back please??

From iCloud.com if you delete the photos they are moved in recently deleted , open the recently deleted select them ( use command and A keys now works in Mac OS catalina 10.15.5 or you can hold shift key click on first photo and the last one to get select , and click on recover all , or if you select single photo click on recover it will again moved to photos and the same will be reflected in photo application of Mac / or iPhone that are configured , but this is to be done before 30 days .

See the article https://support.apple.com/guide/icloud/delete-and-recover-photos-and-videos-mm08b49040b5/1.0/icloud/1.0

For your query , for your old iPhone you can recover from the device itself https://support.apple.com/en-in/HT205856

Is your new iPhone signed in with same apple id and password that you used in old iPhone , if yes they can be recovered from new iPhone ( make sure all steps are to be done before 30 days ) .

A basic rule - if devices are signed in with same Apple ID and password on the same network it could be iPhones / Macs , if you delete a photo from first device it deletes from another device , some conditions are met in iPhone the photo box must be always turned as on https://support.apple.com/guide/iphone/use-icloud-photos-iph961b96c4d/13.0/ios/13.0

In Mac also the photo library and its preferences are correctly set up https://support.apple.com/en-in/HT204264

https://support.apple.com/en-in/guide/photos/pht5156cc968/4.0/mac/10.14

Permanently deleted photos are erased from the server immediately , if you ever had set up time machine then only they can be brought back https://support.apple.com/en-us/HT209152

I did the same thing only just about 10 minutes ago. How do I recover the deleted photos? It will not let me save images to my computer either.