I have 50 gb storage but my photos say storage is full even though there is only 9 gb used?

Well, you supplied a few fragmented facts. Here is some of what I understand:

• You have 50GB of iCloud storage.
• You have 256GB of iPhone storage.
• Your iPhone has used 104 GB of its storage.
• Something (presumably iCloud) has used 9GB of storage.
• Presumably, given your post’s title, Photos are involved.

That’s about all we know. So I will guess you’re trying to transfer photos from your iPhone to iCloud, and simply don’t have enough iCloud storage to house them.

Please go to https://www.icloud.com in a web browser then log in using the Apple ID (email) that you use to log in on your iPhone.

Click on the photos icon. You can then view the photos that are stored in iCloud.

If you have logged into iCloud on other iPhones and iPads in the past, by default, they have saved your photos and videos there.

Aoazoo wrote:

I have 50 gb storage

You’re referring to iCloud storage. That is very different from iPhone storage.

What's the difference between device storage and iCloud storage? - Apple Support